search

knative-extensions / net-istio

A Knative ingress controller for Istio.
Apache License 2.0
76 stars 89 forks source link

How to remove the knative-local-gateway? #1255

Open joke opened 9 months ago

joke commented 9 months ago

Hi,

the documentation in config-istio says the local gateway can be removed if a service mesh is in place:

# A cluster local gateway to allow pods outside of the mesh to access
# Services and Routes not exposing through an ingress.  If the users
# do have a service mesh setup, this isn't required and can be removed.

But I don't see how this can be done. If I don't specify a line like that, the default kicks in: local-gateway.knative-serving.knative-local-gateway: "knative-local-gateway.istio-system.svc.cluster.local"

Causing this error message: type: 'Warning' reason: 'InternalError' failed to get Gateway: gateway.networking.istio.io \"knative-local-gateway\" not found

The support for this mesh syntax has been remove in this pull request.

Regards Joke

dprotaso commented 9 months ago

We're making tweaks to the configuration here: https://github.com/knative-extensions/net-istio/issues/1247

I wonder if it makes sense to better express no localgateway programming in that newer config once that change lands

Though at a minimum it seems like we should update the comment

/triage accepted

joke commented 9 months ago

on that note: support for delegate virtual services would be cool: #1003

dprotaso commented 9 months ago

Can you comment on that issue - with your use case and how it helps you?

lizzzcai commented 2 months ago

want to follow up if it is possible to remove the local gateway from knative?