search

knative-extensions / net-istio

A Knative ingress controller for Istio.
Apache License 2.0
76 stars 89 forks source link

Include Istio version tested/supported in release notes #958

Open AngeloDanducci opened 2 years ago

AngeloDanducci commented 2 years ago

Had someone in Slack ask about supported Istio versions today but our documentation was out of date.

After talking with Dave I think it makes sense to make the docs point directly to the releases page and then include what version of Istio we are supporting/testing in future releases.

dprotaso commented 2 years ago

Any chance we can update the last few releases to mention the version- ie. releases 1.3 to 1.6 are currently in our support window

AngeloDanducci commented 2 years ago

I can go back and update the old releases manually in the meantime 👍

nak3 commented 2 years ago

+1

FYI net-gateway-api adds the release page by this script -https://github.com/knative-sandbox/net-gateway-api/blob/main/hack/release.sh#L69 . Here is the result https://github.com/knative-sandbox/net-gateway-api/releases

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

dprotaso commented 2 years ago

/lifecycle frozen

ReToCode commented 1 year ago

Is there still work to be done here? net-istio does automatically create release notes and we added a link from the docs. @nak3 , @dprotaso?

dprotaso commented 1 year ago

Looks like we made the necessary changes to the website: https://knative.dev/docs/install/installing-istio/#supported-istio-versions

But the latest release doesn't mention the Istio version - https://github.com/knative-sandbox/net-istio/releases

Our release note automation [1][2] will scan PR bodies for release-note blocks and surface those. It still requires a release lead to update the release with these generated notes (hopefully this will be automated (https://github.com/knative/test-infra/issues/3655))

But if the person bumping Istio in a PR didn't include this message (or there was no bump) it's not going to show up.

We could do what @nak3 suggested and create a 'header' for the release note - that's probably the actionable thing for this issue

[1] https://github.com/kubernetes/release/tree/master/cmd/release-notes [2] https://github.com/knative/actions/blob/main/.github/workflows/release-notes.yaml)

dprotaso commented 1 year ago

I just updated the 1.9 release note with Tested with Istio 1.16.0

Nageshbansal commented 1 year ago

Hello @ReToCode @dprotaso, I noticed this issue and would love to contribute. Is it still open for someone to work on?

ReToCode commented 1 year ago

👍 Sure, feel free to assign it to yourself and start working on a PR.

Nageshbansal commented 1 year ago

Sure. And, the current issue is to update the release by adding generated notes and including headers for istio version. Is that correct?

ReToCode commented 1 year ago

Yes: https://github.com/knative-sandbox/net-istio/issues/958#issuecomment-1431743096

We could do what @nak3 suggested and create a 'header' for the release note - that's probably the actionable thing for this issue

Nageshbansal commented 1 year ago

/assign

dprotaso commented 1 year ago

@Nageshbansal are you still interested in working on this issue?

dprotaso commented 1 year ago

/good-first-issue

knative-prow[bot] commented 1 year ago

@dprotaso: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/knative-sandbox/net-istio/issues/958): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Nageshbansal commented 1 year ago

@dprotaso , yes, I'll make the PR soon. Thanks

thesuperzapper commented 5 months ago

@dprotaso @ReToCode This is a very important usability issue, right now there is no way to know which versions of Istio are "officially supported" by what version of Knative.

The only way to know for sure is to test yourself, and issues might not expose themselves until after you have deployed to production.

I would be grateful for a list of Istio versions that each release ran its integration tests on, as this would probably be sufficient.