search

knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 262 forks source link

Fix namespaced unit test #1753

Closed dsimansk closed 2 years ago

dsimansk commented 2 years ago

Description

Fix unit test when run in release jobs.

/cc @nak3 @lionelvillard @rhuss @vyasgun

Changes

Reference

Fixes #

Release Note

NONE
codecov[bot] commented 2 years ago

Codecov Report

Base: 79.89% // Head: 79.89% // No change to project coverage :thumbsup:

Coverage data is based on head (82e08ea) compared to base (0b99fc5). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1753 +/- ## ======================================= Coverage 79.89% 79.89% ======================================= Files 174 174 Lines 13589 13589 ======================================= Hits 10857 10857 Misses 1990 1990 Partials 742 742 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [dsimansk,vyasgun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dsimansk commented 2 years ago

/cherry-pick release-1.8

knative-prow-robot commented 2 years ago

@dsimansk: new pull request created: #1754

In response to [this](https://github.com/knative/client/pull/1753#issuecomment-1283754906): >/cherry-pick release-1.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.