knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 262 forks source link

Fixing errors related to Go 1.20 #1779

Closed scottmason88 closed 1 year ago

scottmason88 commented 1 year ago

Description

This pull request will fix errors that came about with Go 1.20 deprecating rand.Seed.

Changes

Reference

Issue #1775

Release Note

 Fix deprecated functions related to Go 1.20 
linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

knative-prow[bot] commented 1 year ago

Welcome @scottmason88! It looks like this is your first PR to knative/client πŸŽ‰

knative-prow[bot] commented 1 year ago

Hi @scottmason88. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 1 year ago

Codecov Report

Base: 79.88% // Head: 79.87% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (1d24121) compared to base (badd909). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 1d24121 differs from pull request most recent head 55125f9. Consider uploading reports for the commit 55125f9 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1779 +/- ## ========================================== - Coverage 79.88% 79.87% -0.01% ========================================== Files 174 174 Lines 13594 13593 -1 ========================================== - Hits 10859 10858 -1 Misses 1992 1992 Partials 743 743 ``` | [Impacted Files](https://codecov.io/gh/knative/client/pull/1779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Ξ” | | |---|---|---| | [cmd/kn/main.go](https://codecov.io/gh/knative/client/pull/1779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-Y21kL2tuL21haW4uZ28=) | `87.82% <ΓΈ> (-0.21%)` | :arrow_down: | | [pkg/printers/tablegenerator.go](https://codecov.io/gh/knative/client/pull/1779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3ByaW50ZXJzL3RhYmxlZ2VuZXJhdG9yLmdv) | `100.00% <100.00%> (ΓΈ)` | | | [pkg/serving/service.go](https://codecov.io/gh/knative/client/pull/1779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3NlcnZpbmcvc2VydmljZS5nbw==) | `90.32% <100.00%> (ΓΈ)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dsimansk commented 1 year ago

/ok-to-test

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss, scottmason88

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [rhuss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment