search

knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 261 forks source link

Wrong version for kn create kafka channel #1885

Closed Leo6Leo closed 1 year ago

Leo6Leo commented 1 year ago

https://github.com/knative/client/blob/ae35736892402050eb910d2b43a70f41e1d225c4/docs/cmd/kn_channel_create.md?plain=1#L22

The version here should be v1beta1 as we can refer to here

Leo6Leo commented 1 year ago

/cc @Cali0707

Cali0707 commented 1 year ago

Thanks for reporting @Leo6Leo

Cali0707 commented 1 year ago

/good-first-issue

knative-prow[bot] commented 1 year ago

@Cali0707: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/knative/client/issues/1885): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Cali0707 commented 1 year ago

It also shows up here: https://github.com/knative/client/blob/ae35736892402050eb910d2b43a70f41e1d225c4/pkg/kn/flags/channel_types.go#L57

MeenuyD commented 1 year ago

/assign

Cali0707 commented 1 year ago

Thanks for finishing this @MeenuyD !! :tada: