search

knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 261 forks source link

Lower required Codecov coverage #1920

Closed dsimansk closed 8 months ago

dsimansk commented 8 months ago

Description

Changes

@rhuss with release of Golang 1.22 there are changes in coverage calculations and formulas. Hence we dropped a few %. Temporarily lowering the required number on our side until we add a few more % to satisfy project common 80% threshold.

Reference

Fixes #

Release Note

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.58%. Comparing base (0cf5aeb) to head (4548288).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1920 +/- ## ======================================= Coverage 74.58% 74.58% ======================================= Files 207 207 Lines 15563 15563 ======================================= Hits 11607 11607 Misses 3167 3167 Partials 789 789 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rhuss commented 8 months ago

/approve /lgtm

knative-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [dsimansk,rhuss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dsimansk commented 8 months ago

/retest