search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.55k stars 1.23k forks source link

Adding image to cross namespace blog #6075

Closed yijie-04 closed 4 months ago

yijie-04 commented 4 months ago

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

netlify[bot] commented 4 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 9ae5d8fca0ee7085fc10aeb6f5fa5a0bad6f3815
Latest deploy log https://app.netlify.com/sites/knative/deploys/66a3c7e61360b500089a54a2
Deploy Preview https://deploy-preview-6075--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yijie-04 commented 4 months ago

/cc @Cali0707 @Leo6Leo

Leo6Leo commented 4 months ago

The image is not showing in the deploy-review

https://deploy-preview-6075--knative.netlify.app/blog/articles/cross-namespace-event-links-feature/

yijie-04 commented 4 months ago

Hmm I'm not sure why it's not showing, is there an issue with the image?

Leo6Leo commented 4 months ago

/lgtm /approve

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, yijie-04

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)~~ [Leo6Leo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment