search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.55k stars 1.23k forks source link

Improve startup probe hint about progress deadline #6091

Closed ReToCode closed 3 months ago

ReToCode commented 3 months ago

Proposed Changes

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/serving/OWNERS](https://github.com/knative/docs/blob/main/docs/serving/OWNERS)~~ [ReToCode] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 3 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit f6f7dee8d29128b685ceb3485b00586f49efd555
Latest deploy log https://app.netlify.com/sites/knative/deploys/66b5d2191d3e310008ac95ea
Deploy Preview https://deploy-preview-6091--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ReToCode commented 3 months ago

/cherry-pick release-1.15

knative-prow-robot commented 3 months ago

@ReToCode: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to [this](https://github.com/knative/docs/pull/6091#issuecomment-2277424591): >/cherry-pick release-1.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ReToCode commented 3 months ago

/assign @mgencur

mgencur commented 3 months ago

/lgtm

knative-prow-robot commented 3 months ago

@ReToCode: new pull request created: #6092

In response to [this](https://github.com/knative/docs/pull/6091#issuecomment-2277424591): >/cherry-pick release-1.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.