search

knative / func

Knative Functions client API and CLI
Apache License 2.0
274 stars 138 forks source link

when redeploying function in openshift dont force its internal registry #2172

Open gauron99 opened 7 months ago

gauron99 commented 7 months ago

This is a followup for https://github.com/knative/func/pull/1962

when usign openshift cluster its useful to use its internal registry when deploying images. But you might want to use your own image in different registry like (docker.io etc). One can deploy with f deploy --registry=docker.io/XXX and the correct registry will be used. BUT when redeploying after, openshift registry is used overriding the existing one.

Are you willing to work on this yourself? yes

either simple logic refactor for redeploy or a complete registry derivation change is needed here

github-actions[bot] commented 4 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

gauron99 commented 4 months ago

/remove-lifecycle stale

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

gauron99 commented 1 month ago

/remove-lifecycle stale