knative / hack

Knative common scripts.

Apache License 2.0

18 stars 64 forks source link

:broom: Rewrite unit tests in Golang #215

Closed cardil closed 2 years ago

cardil commented 2 years ago

Changes

:broom: Rewrite unit tests in Golang
:broom: Fix scripts to survive in the set -Eeuo pipefail mode

/kind cleanup

Fixes #61

knative-prow[bot] commented 2 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

cardil commented 2 years ago

/test all

cardil commented 2 years ago

https://github.com/kubernetes/test-infra/issues/27358 blocks this PR

/hold

cardil commented 2 years ago

/unhold

https://github.com/kubernetes/test-infra/issues/27358 wasn't the cause of the unit test failure.

It was due to:

https://github.com/knative/hack/blob/f9dc7220d36264f5aa2a304b3663612815b757bc/library.sh#L70

It was fixed in 8ba8bc0e2d71d17f4d77cf949ea25f5712a05404

cardil commented 2 years ago

/assign @kvmware /assign @upodroid /cc @mgencur

cardil commented 2 years ago

/test unit-tests_hack_main

cardil commented 2 years ago

I'd like this merged, before I could work on https://github.com/knative/hack/issues/221

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [cardil,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment