knative / hack

Knative common scripts.

Apache License 2.0

18 stars 64 forks source link

Notarize Mac binaries #231

Closed upodroid closed 2 years ago

upodroid commented 2 years ago

Part of https://github.com/knative/test-infra/issues/3536

Changes

Allows mac binaries (GOOS=darwin) to be notarized.
I need to upload the credentials to Google Secret Manager, load it to K8s and modify release/nightlies to use it.

/cc @cardil @kvmware

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

krsna-m commented 2 years ago

/lgtm