Fix some bugs in the notarizing logic

knative / hack

Knative common scripts.

Apache License 2.0

18 stars 64 forks source link

Fix some bugs in the notarizing logic #234

Closed upodroid closed 2 years ago

upodroid commented 2 years ago

There were a few bugs from #231 that I have fixed.

I have enrolled one nightly for this. https://prow.knative.dev/prowjob?prowjob=aacfd670-4362-11ed-83e3-922558be6d19

/cc @cardil

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

upodroid commented 2 years ago

/cc @kvmware

krsna-m commented 2 years ago

/lgtm