knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

:gift: Use Knative ls-tags tool #238

Closed cardil closed 2 years ago

cardil commented 2 years ago

Changes

/kind enhancement

Related https://github.com/knative/actions/pull/72

Release Note

Use Knative ls-tags tool
knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [cardil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cardil commented 2 years ago

/hold

cardil commented 2 years ago

/assign @upodroid /assign @kvmware /cc @jrangelramos /cc @mgencur

jrangelramos commented 2 years ago

/lgtm

cardil commented 2 years ago

/test unit-tests

We should add prefetching of test-infra, as when it updates the test might fail.

cardil commented 2 years ago

IDK why such error happens:

error: could not lock config file .git/config: File exists

/test unit-tests

upodroid commented 2 years ago

Seen that before, it is a flaky behaviour of the build system

cardil commented 2 years ago

/unhold