search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Calculate Image references properly #251

Closed upodroid closed 2 years ago

upodroid commented 2 years ago

Closes: https://github.com/knative/serving/pull/13408 Part of https://github.com/knative/infra/issues/99

Some repos (eventing/serving and others) override the ko flags so this change calculates the image references directly from the yaml manifests that are uploaded.

/cc @dprotaso @kvmware

krsna-m commented 2 years ago

Dont know enough about ko to think of a more clever way so lgtm

dprotaso commented 2 years ago

/lgtm /approve

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [dprotaso,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment