knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Add shell linter github action #274

Closed kauana closed 1 year ago

kauana commented 1 year ago

Changes

/kind enhancement

Fixes #269

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kauana Once this PR has been reviewed and has the lgtm label, please ask for approval from cardil. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 1 year ago

Hey there, sorry for this hanging here for so long. I think the correct solution is to add hack repo to knobots to use the style directive. That way the workflow is managed by the automation system. There is examples of the style reusable action in serving, eventing, etc. that uses this system.

kauana commented 1 year ago

Hey @kvmware, sorry for the wait as well! I believe knative/hack is already added to knobots, but the github actions are currently excluded for this repo.

If that's ok with you, I'm happy to update that so knative/hack can take advance of the style action. Thanks

krsna-m commented 1 year ago

That should work thanks