search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

:bug: Find checksums file works with ARTIFACTS_TO_PUBLISH variable #275

Closed cardil closed 1 year ago

cardil commented 1 year ago

Changes

/kind bug

Fixes https://github.com/knative/hack/issues/272 Follow up to https://github.com/knative/hack/pull/268

cardil commented 1 year ago

/cc @upodroid /cc @kvmware /cc @psschwei /cc @evankanderson

cardil commented 1 year ago

/cherrypick release-1.9

knative-prow-robot commented 1 year ago

@cardil: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to [this](https://github.com/knative/hack/pull/275#issuecomment-1433174005): >/cherrypick release-1.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cardil commented 1 year ago

@upodroid: Not a blocker, but what is the kn-event release script doing that is different from the other kn-* scripts?

The kn-plugin-repo is unique in a couple of places. I often use it as a proving grounds for new development approaches.

A couple of differences from the top of my head:

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, evankanderson, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [cardil,evankanderson,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cardil commented 1 year ago

/hold cancel

knative-prow-robot commented 1 year ago

@cardil: new pull request created: #276

In response to [this](https://github.com/knative/hack/pull/275#issuecomment-1433174005): >/cherrypick release-1.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.