search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Revert "Extract tools to knative.dev/toolbox (#280)" #281

Closed krsna-m closed 1 year ago

krsna-m commented 1 year ago

This reverts commit 1421f120c36bafe645a1b5e528382d25960218b4.

krsna-m commented 1 year ago 
knative.dev/toolbox/kntest/cmd/kntest@latest (in knative.dev/toolbox/kntest@v0.0.0-20230406165419-0318b24a34cf):
    The go.mod file for the module providing named packages contains one or
    more replace directives. It must not contain directives that would cause
    it to be interpreted differently than if it were the main module.

People are seeing this issue across projects. Having this ready in case this issue can't be resolved in a timely manner.

/hold give some time to see if we can get this fixed in toolbox

dprotaso commented 1 year ago

/lgtm /approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [dprotaso,kvmware] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 1 year ago

/unhold @cardil won't be back til tomorrow and that is too long to wait.