search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Fix bug that broke signatures #284

Closed upodroid closed 1 year ago

upodroid commented 1 year ago

/cc @cardil @kvmware @BobyMCbobs

The change in #268 broke image signatures. I'm also copying the image refs and attestations to the artifacts folder for easy verification.

I need to write a tool to easily check sigstore signatures on all the nightly jobs.

upodroid commented 1 year ago

/retest

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [cardil,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cardil commented 1 year ago

Thanks for the fix @upodroid!

BobyMCbobs commented 1 year ago

Thank you @upodroid! bash sure does have it's moments