knative / hack

Knative common scripts.

Apache License 2.0

18 stars 64 forks source link

Install Istio for e2e tests #291

Closed kauana closed 1 year ago

kauana commented 1 year ago

Changes

Installs Istio (ever since the istio addon stopped being supported, Istio hasn't been installed). The recent probe additions to net-istio probably caused the tests to fail because Istio wasn't installed.
Follows the same flow used by knative/client

Fixes #290 Related issue #269

knative-prow[bot] commented 1 year ago

@kauana: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative/hack/pull/291): > > ># Changes > > > >- >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

dprotaso commented 1 year ago

/assign @kvmware /unassign @psschwei @dprotaso

krsna-m commented 1 year ago

/lgtm /approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kauana, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [kvmware] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment