knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Update e2e-kind.sh #307

Closed davidhadas closed 7 months ago

davidhadas commented 1 year ago

manual renaming

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidhadas Once this PR has been reviewed and has the lgtm label, please assign kvmware for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
krsna-m commented 1 year ago

We was instructed to do so https://cloud-native.slack.com/archives/C04LY4M2G49/p1692208028070579?thread_ts=1692207828.557749&cid=C04LY4M2G49 here before as well.

This will not be merged with failing tests /hold until lint tests are fixed

davidhadas commented 1 year ago

The owners of this repo need to fix it. I am not going to fix repos who have broken lint and other tests not related to renaming.

We was instructed to do so https://cloud-native.slack.com/archives/C04LY4M2G49/p1692208028070579?thread_ts=1692207828.557749&cid=C04LY4M2G49 here before as well.

@kvmware oh well, if you instructed... obedience is the only way forward... Your attitude is unacceptable. And not helpful in any way.

krsna-m commented 1 year ago

Not meant to upset, but part of the agreement for the renaming initiative you requested was that you would have to do more than run a simple sed to rename things and help get repos working with the new rename. So far, you have not done any of that which you agreed to and now extra work is landing on us (infra) and repo owners which was something that we explicitly mentioned that we didnt want to see.

davidhadas commented 1 year ago

Not meant to upset, but part of the agreement for the renaming initiative you requested was that you would have to do more than run a simple sed to rename things and help get repos working with the new rename. So, far you have not done any of that which you agreed to and now extra work is landing on us (infra) and repo owners which was something that was explicitly we didnt want to see.

That is completely incorrect and represent your own attitude against this effort from day 1.

It was explicitly decided that the responsibility is on the owners of the repos to make the changes

I did volunteer to steer this effort, however given what you wrote, until there is a clear decision on this at the TOC and clear agreement as for repo owners taking responsibility, I am not going to volunteer any more of my time to this effort.

upodroid commented 1 year ago

This isn't helpful.

Krsna rightfully felt from the beginning that this was a very large and complex endeavour, but we did a good job so far with mitigating his concerns and delivering it so let's get this over the finish line. The changes the linter is asking for are extremely trivial and far less than we spent on writing these comments.

davidhadas commented 7 months ago

no loger relevant