Open matzew opened 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: matzew Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Tekton was doing similar before: https://github.com/tektoncd/plumbing/pull/2042
I was getting a lot of
E0903 10:38:10.600391 51037 library.go:117] Package crypto/aes does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
W0903 10:38:10.600398 51037 library.go:101] "golang.org/x/crypto/chacha20poly1305" contains non-Go code that can't be inspected for further dependencies:
/home/matzew/go/src/knative.dev/serving/vendor/golang.org/x/crypto/chacha20poly1305/chacha20poly1305_amd64.s
W0903 10:38:10.616318 51037 library.go:101] "golang.org/x/crypto/internal/poly1305" contains non-Go code that can't be inspected for further dependencies:
/home/matzew/go/src/knative.dev/serving/vendor/golang.org/x/crypto/internal/poly1305/sum_amd64.s
W0903 10:38:10.623869 51037 library.go:101] "golang.org/x/sys/cpu" contains non-Go code that can't be inspected for further dependencies:
/home/matzew/go/src/knative.dev/serving/vendor/golang.org/x/sys/cpu/cpu_x86.s
E0903 10:38:11.100804 51037 library.go:117] Package net/rpc does not have module info. Non go modules projects are no longer supported. For feedback, refer to https://github.com/google/go-licenses/issues/128.
F0903 10:38:16.129641 51037 main.go:77] some errors occurred when loading direct and transitive dependency packages
hence I am proposing this
@matzew what's the exact error related to toolchain
directive? The warning about native files are present for a long time in go-licenses check.
I personally find this a bit annoying:
F0904 08:18:20.345646 54599 main.go:77] some errors occurred when loading direct and transitive dependency packages
exit status 1
--- FAIL: go-licenses failed the license check
Command '__go_update_deps_for_module' failed in module /home/matzew/go/src/knative.dev/eventing: 1
Am I the only one w/ the exit status
and FAIL:
?
I personally find this a bit annoying:
F0904 08:18:20.345646 54599 main.go:77] some errors occurred when loading direct and transitive dependency packages exit status 1 --- FAIL: go-licenses failed the license check Command '__go_update_deps_for_module' failed in module /home/matzew/go/src/knative.dev/eventing: 1
Am I the only one w/ the
exit status
andFAIL:
?
What's the command you are running it through here?
This should fixes issues we are getting with
go.mod
files containing thetoolchain
directive.See google/go-licenses#128.