knative / pkg

Knative common packages
Apache License 2.0
259 stars 331 forks source link

Use istio.sidecar.inject label instead of annotation #3096

Closed ReToCode closed 1 month ago

ReToCode commented 2 months ago

Partially https://github.com/knative/serving/issues/15521

Proposed Changes

/assign @skonto

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.45%. Comparing base (aabe552) to head (369cfcb). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/crd.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3096 +/- ## ======================================= Coverage 78.45% 78.45% ======================================= Files 191 191 Lines 8938 8938 ======================================= Hits 7012 7012 Misses 1663 1663 Partials 263 263 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 1 month ago

/lgtm /approve

knative-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/knative/pkg/blob/main/test/OWNERS)~~ [ReToCode,dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 1 month ago

actually might need a follow up depending on the answer to this question:

https://github.com/knative-extensions/net-istio/pull/1369#issuecomment-2371351757