search

knative / ux

UX WG repository for assets and stories
11 stars 23 forks source link

[bug] The Knative bi-weekly UX WG meeting reminder slack bot is sending reminders every week #176

Closed Leo6Leo closed 3 months ago

Leo6Leo commented 4 months ago

As described in the title, the Knative bi-weekly UX WG meeting reminder slack bot is sending reminders every week.

The yaml file that is used to configure this github action is here

The reminder is sent to the CNCF slack #knative-ux channel. One example message is https://cloud-native.slack.com/archives/C05MW1AT1T8/p1722431220346959.

The next/most recent bi-weekly UX WG meeting will be happening August 8th, 2024.

Warn: In order to test the feature, the PR has to be merged for GitHub action to run.

/good-first-issue /help-wanted /kind bug

knative-prow[bot] commented 4 months ago

@Leo6Leo: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/knative/ux/issues/176): > >As described in the title, the Knative bi-weekly UX WG meeting reminder slack bot is sending reminders every week. > >The yaml file that is used to configure this github action is [here](https://github.com/knative/ux/blob/main/.github/workflows/bi-weekly-UX-WG-meeting-reminder.yaml) > >The reminder is sent to the CNCF slack #knative-ux channel. One example message is https://cloud-native.slack.com/archives/C05MW1AT1T8/p1722431220346959. > >The next/most recent bi-weekly UX WG meeting will be happening August 8th, 2024. > >Warn: In order to test the feature, the PR has to be merged for GitHub action to run. > >/good-first-issue >/help-wanted >/kind bug Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Alokih commented 4 months ago

Hey @Leo6Leo , Can I try this issue ?

Alokih commented 4 months ago

I think the issue here is that we need to add 'needs: weekindex' in reminds section , to make sure that remind job runs only after the weekindex job completes

Leo6Leo commented 4 months ago

Absolutely @Alokih , thanks for taking on this task.

/assign @Alokih

Alokih commented 4 months ago

Hey @Leo6Leo I have created a PR

Leo6Leo commented 3 months ago

@Alokih Thank you for your PR, I have left the comment on your PR, PTAL