search

kneo / indi-bresserexos2

Indi Driver for Bresser Exos II GoTo Mount Controller.
20 stars 4 forks source link

Handset time set to UTC instead of local #8

Closed rcreswell closed 3 years ago

rcreswell commented 3 years ago

I have discovered that when setting the Site Management Element 'UTC' the set action changes the JOC handset time to UTC time instead of local time. The time on the handset changes to the 'UTC Time' setting irrespective of the 'UTC Offset' setting instead of calculating the handset local time (e.g., the offset has no impact).

I first noticed this when I used the UTC set time facility and targets were being reported as 'UdHn' (Under Horizon) on the mount's handset when planetarium software indicated that they weren't.

Note: I entered the offset as -7 (W08 time zone in daylight savings).

kneo commented 3 years ago

Yes, see issue #6, its already fixed in the latest release. You can wait until your distributor updates the packages, or build the driver yourself using the latest main branch.

rcreswell commented 3 years ago

The behavior was exhibited on the latest main branch build. I cleared the old installation out and started fresh just to be sure. I also varied the UTC offset setting to see if there was any impact on the handset time setting but there was none. Whatever is put in the element 'UTC' is the time that the handset is set to. Any value placed in 'UTC Offset' has no impact on the handset time.

As a work around, the handset picks up local time when power is applied to the mount controller (provided you don't wait any period). As long as you don't try to use the INDI Control Panel's Site Management Element 'UTC', everything performs normally.

Regards and thanks again for the development of this driver.

Ron

kneo commented 3 years ago

I think I fixed it, you can check out the latest main branch, and retry. There were also still some issues with the location, I hopefully fixed those too.

rcreswell commented 3 years ago

I removed the prior build and reinstalled the main branch from scratch. After testing the Site Management Element 'UTC' and 'UTC Offset' the INDI Control Panel set action still places the Exos-2gt handset time to UTC time. Varying the 'UTC Offset' parameter also continues to have no effect.

Lat/Lon entries continue to work fine.

kneo commented 3 years ago

you need to click the "time" button followed by "OK" in the dialog box, the "set" button only affects the geo location setting.

rcreswell commented 3 years ago

Kevin,

The INDI Control Panel in KStars does, as you indicate, show 'Time' button for the UTC parms but other INDI Control Panel clients like IPARCOS and the iPhone CloudMakers iOS app show 'Set' for the UTC parms instead.

In any case, I tried all three clients (including the use of 'Time'/'OK' buttons in the KStars client) with the same effect. The UTC field entry becomes the handset time regardless of the 'UTC Offset' entry.

Ron

kneo commented 3 years ago

I'm sorry to steal your time! I looked through the other drivers shipped with indi, and shamelessly stole code from a celestron driver which happens to work in a similar way. You now should be able to set the utc time and the hand box should adjust accordingly.

rcreswell commented 3 years ago

Thanks Kevin. I'm the one stealing your time. I'd like to personally shake your hand for all of this skilled workmanship if it were possible.

Regards,

Ron

kneo commented 3 years ago

Thanks for your feedback, I take it its working now as expected and the issue can be closed?

rcreswell commented 3 years ago

I am pleased to report that the UTC time setting feature is now working correctly with UTC and offset entry setting the handset to the correct local time. Thanks once again Kevin.

kneo commented 3 years ago

I forgot to remove a wrong offset so the year was wrong ... the latest checkout will fix that. Never ever mess with time ...

rcreswell commented 3 years ago

Ya, I saw that. The year was 3921 (1900 years future). The number 1900 seemed like a clue to me. You were one step ahead of me.

Best Regards Kevin,

Ron Creswell

From: Kevin Krüger @.> Sent: Thursday, August 19, 2021 3:09 PM To: kneo/indi-bresserexos2 @.> Cc: rcreswell @.>; Author @.> Subject: Re: [kneo/indi-bresserexos2] Handset time set to UTC instead of local (#8)

I forgot to remove a wrong offset so the year was wrong ... the latest checkout will fix that. Never ever mess with time ...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kneo/indi-bresserexos2/issues/8#issuecomment-902283486 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AU5GXUKEDT7BXFGSAJ5SM23T5V6JNANCNFSM5CK75NHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email . https://github.com/notifications/beacon/AU5GXUIILIYV45Q6LYTDLQTT5V6JNA5CNFSM5CK75NHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGXD4BXQ.gif