knightcrawler-stremio / knightcrawler

A selfhosted Stremio addon
Apache License 2.0
314 stars 43 forks source link

User preferences ignored #50

Open funkypenguin opened 9 months ago

funkypenguin commented 9 months ago

Hey all,

I've had a few users reporting this on reddit and in ElfHosted discord, haven't looked into it yet, but wanted to raise it incase anybody else has seen it, or incase I have a stupid misconfiguration bug somewhere :)

Describe the bug

When a user selects preferences like "no 4K, primary foreign language DE", these are ignored by the addon, and all results are still displayed when the user searches.

To Reproduce

Attempt to configure user preferences on https://torrentio.elfhosted.com/, observe that your preferences are not respected :)

Expected behavior

Preferences would affect the results return from a user search via the addon

Gabisonfire commented 9 months ago

Can confirm this is happening on my setup as well, might be related to https://github.com/Gabisonfire/torrentio-scraper-sh/issues/31

Ulinsky commented 9 months ago

This is happening to me, this is the config Im using: image image

4k excluded, no foreign language, 2 results per quality.

And the result Im getting: image

4k included, 2 results total instead of per quality, italian language instead of english for the 1080p result.

With the same torrentio config for the same episode: image

these are the results Im getting: image

either english or dual audio with english included, no 4k, 2 results per quality instead of 2 results total.

dreulavelle commented 9 months ago

Here is how I handle this in my other application. I've truncated it down some so that its more standalone here. The logic/methods are pretty straightforward. You'd just call parse method on a string, and it returns a dict. The fetch key is what you'd used to determine if the item is worth fetching or not. It's in python, so you'll need to convert.

Feel free to take what you can use, if its useful at all. Let me know if you have questions, I'm Spoked on discord.

https://github.com/dreulavelle/Nexus/blob/main/utils/parser.py