Open gab1one opened 8 years ago
I'm not sure if we need the extra @Attr
anymore.
@dietzc Maybe a second StyleHook constant?
If we have to add a hook, then certainly a StyleHook
. However we have to be careful and think this through in all detail:
Use-case 1:
ModuleInfo
(either enforced by a hook or because there is no widget for it):New Table
, Append Columns
, Replace Column
(by many).Use-case 2:
Array
input for which no dialog-widget exists, e.g. ImgPlus<T>
[] or List<ImgPlus<T>>
or ... This results in one or many multi-column selections where you can select the columns. Please note that we may have to use the generic-type-matching magic of @ctrueden in case of generics and nested generics.New Table
, Append Columns
Use-case 3:
Float[]
input for which a dialog-widget exists as well as a special cell-type in KNIME. For this Float[]
we could enforce a column-selection but also a multi-column-selection.New Table
, Append Columns
and Replace
if single column selection.So yes we need another enforcer-hook but we also need more. Let me know if it makes sense what I wrote and if not, what your concerns are.
So yes we need another enforcer-hook but we also need more. Let me know if it makes sense what I wrote and if not, what your concerns are.
The "need more" only refers to code outside of the Scijava command, like the output-table-style etc., right?
We can add a Multi-Column Selection in this case
Meaning, we will add a Multi-Column Selection in this case, right?
Everything else makes total sense, I think those use cases are well separated :+1:
The "need more" only refers to code outside of the Scijava command, like the output-table-style etc., right?
We need to handle all the other use-cases. The output-table-style is a different issue (would be great if you could open the issue with a first proposal what we do on this front).
Meaning, we will add a Multi-Column Selection in this case, right?
Can in the sense of: we are allowed without being inconsistent. So yes, we will ;-)
If a command has only one input which is assigned to a column selection, e.g one input image, we should create a multi column selection for that input.
Notes
We need to have a multi column selection for input parameters. E.g. when we want to apply a filter to several image columns in a table.
Ideas:
Manual
JAVA:
JavaScript:
Automatic
Commandinputs fitting the following parameters will always get multi col select: