search

knockout / tko

🥊 Technical Knockout – The Monorepo for Knockout.js (4.0+)
http://www.tko.io
Other
273 stars 34 forks source link

Add preventDefault option to event bindings #148

Closed danieldickison closed 2 years ago

danieldickison commented 2 years ago

Here's my attempt at #147 to add a preventDefault option to event bindings, as an alternative to having the handler function return a boolean.

danieldickison commented 2 years ago

Feel free to merge.

Am I able to merge this into the upstream myself? I assumed you'd need to initiate that merge. (Sorry, I'm not too familiar with the workflow in github.)

brianmhunt commented 2 years ago

Am I able to merge this into the upstream myself? I assumed you'd need to initiate that merge. (Sorry, I'm not too familiar with the workflow in github.)

I'm not sure. 😄 I merged it in any case, now.