search

knockout / tko

🥊 Technical Knockout – The Monorepo for Knockout.js (4.0+)
http://www.tko.io
Other
273 stars 34 forks source link

Re-enable tests on builds/knockout #162

Closed brianmhunt closed 2 years ago

brianmhunt commented 2 years ago

Disabled because the global ko is undefined and dummyTemplateEngine wasn't properly importing.

This may be a canary for other build issues since switching to esbuild, which we'll undoubtedly need to resolve sooner rather than later.

brianmhunt commented 2 years ago

Noting:

image
brianmhunt commented 2 years ago

To fix this we just need to remove test: target from knockout/Makefile and then see if make test works.