Binance futures URL problem

[rizer1980]

douggie m1dnightc0der after accept this PR 4785 no chance to get futures binance.

thirst error in BinanceExchange, String FUTURES_URL = "https://dapi.binance.com"; it must be fapi second in BinanceBaseService constructor if sandbox = false, and futures = true, we get
BinanceFuturesAuthenticated binanceFutures URI = "https://dapi.binance.com";

[douggie]

Let me push a pR.

Did not realise this was merged, I should have pulled it.

2 mins

On Fri, Dec 22, 2023 at 4:26 AM Ilya Smirnov @.***> wrote:

douggie https://github.com/douggie m1dnightc0der https://github.com/m1dnightc0der after accept this PR 4785 no chance to get futures binance.

thirst error in BinanceExchange, String FUTURES_URL = "https://dapi.binance.com"; it must be fapi second in BinanceBaseService constructor if sandbox = false, and futures = true, we get BinanceFuturesAuthenticated binanceFutures URI = "https://dapi.binance.com ";

— Reply to this email directly, view it on GitHub https://github.com/knowm/XChange/issues/4807, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBUO2TNJST5HZPFXC62WODYKUDYFAVCNFSM6AAAAABA7J7I76VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TGMZWGM4TANQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[douggie]

Arggh, develop have been updated quite a bit and i need to resolve the conflicts, won't be abel to do it until after christmas.

On Fri, Dec 22, 2023 at 10:25 AM Douggie melville-clarke < @.***> wrote:

Let me push a pR.

Did not realise this was merged, I should have pulled it.

2 mins

On Fri, Dec 22, 2023 at 4:26 AM Ilya Smirnov @.***> wrote:

douggie https://github.com/douggie m1dnightc0der https://github.com/m1dnightc0der after accept this PR 4785 no chance to get futures binance.

thirst error in BinanceExchange, String FUTURES_URL = "https://dapi.binance.com"; it must be fapi second in BinanceBaseService constructor if sandbox = false, and futures = true, we get BinanceFuturesAuthenticated binanceFutures URI = " https://dapi.binance.com";

— Reply to this email directly, view it on GitHub https://github.com/knowm/XChange/issues/4807, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBUO2TNJST5HZPFXC62WODYKUDYFAVCNFSM6AAAAABA7J7I76VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TGMZWGM4TANQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[rizer1980]

i make some quick fix, for a while. https://github.com/rizer1980/XChange-public-fork/tree/binance-dapi-fix_no-PR it's break portfolio margin, because i am not understand why we need both of this:

BinanceFuturesAuthenticated binanceFutures;
BinanceFuturesAuthenticated inverseBinanceFutures;

and just didn’t dig deeper)

[hewardemb]

any news about this issue ?

[rizer1980]

@douggie Will you fix it?