known-as-bmf / plugin.video.arteplussept

Plugin Kodi (ex XBMC) permettant de voir les vidéos disponibles sur Arte +7
GNU General Public License v2.0
44 stars 23 forks source link

Add new folders in the main menu: "Newest", "Most viewed" and "Last chance" #55

Closed goggle closed 5 years ago

goggle commented 6 years ago

This PR adds three new folders to the main menu of the plugin: "Newest" (which contains a list of the most recent ARTE videos), "Most viewed" (which contains a list of the most viewed videos) and "Last chance" (which contains a list of videos that will soon be offline). So this PR allows the user of the plugin to browse through the ARTE videos in a more natural way.

Caveat: The API request does not return any deeper information about the videos, so there won't be any video description available for the videos in these three folders.

known-as-bmf commented 6 years ago

Maybe it's worth looking into this endpoint as well:

http://www.arte.tv/hbbtvv2/services/web/index.php/EMAC/teasers/home/v2/fr

There is a lot more information about the videos. The downside is that the lists are limited to 20 items.

{
    "teasers": {
        "highlights": [...],
        "playlists": [...],
        "creative": [...],
        "mostRecent": [...],
        "mostViewed": [...],
        "lastChance": [...]
    }
}
goggle commented 6 years ago

Hi @known-as-bmf,

Thanks for the suggestion. I have modified the code to use this suggested API request. I don't think that limit of 20 items is a problem. The lists should just be convenient for the user of this plugin to scroll through and see, if there is an interesting video to watch.

There is one problem though: The "mostRecent" section in the json contains only "Silex and the City" videos, but https://www.arte.tv/fr/videos/plus-recentes/ contains completely different videos. Maybe this is just a temporary flaw in the ARTE API. But if this is permanent, we cannot use this method.

What do you think?

goggle commented 6 years ago

The problem with the most recent videos seems to be resolved. What do you think about this PR?

known-as-bmf commented 6 years ago

I think the "most recent" videos actually are "most recently uploaded file in the paltform" rather than "last aired program"... Is it really useful to browse this items ?

goggle commented 6 years ago

I'm not certain about this, but it's indeed possible. When I tested it before, the listed videos (language of the plugin was set to de) were the same as listed under https://www.arte.tv/de/videos/neueste-videos/.

For me, it would be very useful to be able to browse the most recent videos. When I open the plugin, I usually want to see what's new and not have to click through all these topic menus. I guess many other users would like this too. See #52 for a somehow related proposal.

goggle commented 5 years ago

@known-as-bmf Thanks for the review. I've implemented the requested code review changes. Let me know if I should squash the commits or if there is anything else to do.

known-as-bmf commented 5 years ago

I squashed via the github pull-request merge :)

Thanks for the contribution !!

goggle commented 5 years ago

@known-as-bmf Thanks for merging this! Do you plan to make a new minor release soon, so that we can enjoy this feature?