search

knqyf263 / pet

Simple command-line snippet manager
MIT License
4.41k stars 222 forks source link

Parameters width and position modification #259

Closed jaroslawhartman closed 6 months ago

jaroslawhartman commented 7 months ago

Issue #, if available:

Description of changes:

As discussed in PR #250:

Eventually, the changes are:

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

RamiAwar commented 6 months ago

Thanks @jaroslawhartman! Will check it out soon 😁 Really wanna play around with it!

RamiAwar commented 6 months ago

So I tried it out, and I have a few comments: 1- I think the left aligned boxes are more practical because its easier to read (based on how the eye scans info), offers a bit more horizontal space, and since they're aligned it feels to me like its more compact.

2- This actually helped me uncover a bug 😁 Check this out: There's no way to see the last parameter here \<b> unless you scroll down!

image

I think keeping it compact and reducing the vertical padding reduces the chances of this happening. The goal of this page is to make users enter information as fast as possible, so the more compact the view the better I'd say.

I don't think fixing the vertical scroll issue should be part of this PR. For now I'd say just make the boxes wider but I slightly prefer the left alignment. What do you think?