knro / indiwebmanager

Web Manager for INDI Server
http://www.indilib.org
GNU Lesser General Public License v2.1
43 stars 32 forks source link

manage indihub-agent process via INDI-server Web Manager #41

Closed dencoded closed 4 years ago

dencoded commented 4 years ago

This PR includes new API-endpoints and WEB-UI changes to control indihub-agent process.

The indihub-agent is an optional process which can be run on the side of the indiserver process and can be stopped at any moment without affecting indiserver process.

However, if indiserver process is stopped this will lead to be indihub-agent process stopped as well as indihub-agent needs INDI-server to keep running.

New API endpoints:

Web-UI flow changes:

  1. INDI-Server is Off, it is not possible to run indihub-agent without INDI-Server

    Screen Shot 2020-03-08 at 1 07 08 PM
  2. INDI-Server is running but indihub-agent is switched off (not running)

    Screen Shot 2020-03-08 at 1 06 22 PM
  3. Run indihub-agent in some mode (i.e. share-mode) when INDI-Server is running

    Screen Shot 2020-03-08 at 1 07 49 PM
  4. Stop indihub-agent (switch to off-mode) while keep INDI-Server running

    Screen Shot 2020-03-08 at 1 08 12 PM
knro commented 4 years ago

Great work! Since the UI is designed to work for tablets/phones, I think it can be a little more compact.

Power Off.. simply use an icon for each respect action, when a confirmation dialog before taking the action itself so that the user verifies the operation. Use tooltip if user hovers (not available in mobile devices, but at least they get confirmation). Use the same standard icon theme we utilize.

Agent Mode. Again, needs to be simple with tooltips explaining what each option means. The INDIHUB Network Agent Control itself could be the link to indihub.space.. i.e. no need to mention it explicitly below. Alternatively, you can add an icon with the help symbol and upon clicking it would take you there.

dencoded commented 4 years ago

@knro please take another look

I think it looks more compact and cleaner now.

Poweroff/Reboot buttons and new layout for INDIHUB Agent control with help-icon link at the top:

Screen Shot 2020-03-10 at 5 07 48 PM

Tooltips over buttons:

Screen Shot 2020-03-10 at 5 08 05 PM

Confirmation modal dialog before poweroff or reboot:

Screen Shot 2020-03-10 at 5 08 23 PM

Tooltips over agent modes

Screen Shot 2020-03-10 at 5 20 18 PM

Smaller screens:

Screen Shot 2020-03-10 at 5 27 26 PM