Units: `Wyrm` ID -> `Frostfire Monarch`

knyghtmare / War_of_Legends

An add-on for the Battle for Wesnoth, a turn-based strategy game. This add-on is a multiplayer era featuring my favorite factions. It is required as a dependency to play several campaigns.

GNU General Public License v2.0

7 stars 6 forks source link

Units: `Wyrm` ID -> `Frostfire Monarch` #179

Open knyghtmare opened 1 month ago

knyghtmare commented 1 month ago

Describe the desired feature

Just another instance of devs breaking add-ons by adding a unit with ID that already exists in this add-on. They should get hexed by witches at this point...
WoL-using Add-ons affected:
- Journey of a Frost Mage
- Legends Conquest
- Struggle for Freedom
- Need to check if others are affected as well

knyghtmare commented 1 month ago

The breaking PR: https://github.com/wesnoth/wesnoth/pull/7859

babaissarkar commented 1 month ago

I'd suggest not using "Wyrm Dragon", since Wyrm and Dragon have very similar meanings. So far in Wesnoth I saw that Wyrms mean two legged reptiles with two wings and two feet, while Dragons have four feet and two wings.

Even worse, I did some quick research and found this: https://www.christophercant.com/articles/dragons-wyverns-drakes-wyrms

What we are referring to as "Wyrm" should actually be "Wyvern".

Draconic Creatures

More info: https://en.wikipedia.org/wiki/Wyvern, https://dragons.fandom.com/wiki/Wyvern

My suggestion: Ice Wyvern

knyghtmare commented 1 month ago

This will be affecting just 1.19.x for now so maybe I will wait until the 1.19.x server is officially created. There is also the issue of 1.18.x clients which won't have the new core unit.

knyghtmare commented 1 month ago

until the 1.19.x server is officially created.

It seems to exist since April 2024...but no announcement...how odd. I guess it's time to make the 1.18.x branch for WoL

knyghtmare commented 2 weeks ago

Update: tentative final name: Frostfire Monarch