search

koajs / router

Router middleware for Koa. Maintained by @forwardemail and @ladjs.
MIT License
862 stars 176 forks source link

Support Preflight CORS requests #45

Closed julienw closed 4 years ago

julienw commented 4 years ago

Fixes #44

Kindly see issue #44 for more information about this patch. Thanks!

JacobMGEvans commented 4 years ago

@niftylettuce thoughts?

niftylettuce commented 4 years ago

Seems like this will require a major version bump, would you agree @JacobMGEvans ?

JacobMGEvans commented 4 years ago

I am not seeing any breaking changes internally, and issue #44 details out the change really well (probably needs to be added to some documentation).

However, people might have code set up expecting the 200 behavior therefore I would agree that a major bump with a release note annotating the change would be a good idea.

moritzruth commented 4 years ago

When are you planning to release it?

Sinewyk commented 4 years ago

I added info in #44

TL;DR: it's not a bug, it's a feature.