kobenguyent / codeceptjs-applitoolshelper

MIT License
4 stars 5 forks source link

Image difference is not failing the test or no option to make test fail if there is image difference #9

Closed AugustineJosephAlludo closed 8 months ago

AugustineJosephAlludo commented 8 months ago
  1. When there is a difference between Checkpoint Image and Baseline image test is not failing or no option to fail it via a parameter to do the same. Expected Behaviour: Test should fail or there should be option make it fail based on the difference between Checkpoint Image and Baseline image.

  2. Also Error is happening which causes confusion while checking logs:

    Screenshot 2024-01-20 at 7 35 05 PM
  3. Helper should be independent of node version. Like it should be working in any version, not for too old versions at least from node version 14 to latest stable

AugustineJosephAlludo commented 8 months ago

@kobenguyent could you please fix these 3 issues

kobenguyent commented 8 months ago

Hey @AugustineJosephAlludo thanks for your report! Please provide a sample repo if possible so that we could reproduce your findings, hence it's easier to fix them faster.

AugustineJosephAlludo commented 8 months ago

Hi @kobenguyent due to security concerns from our client we are not able to provide sample repo. I have only used the I.eyeCheck method in the following way:

kobenguyent commented 8 months ago

:tada: This issue has been resolved in version 1.2.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

kobenguyent commented 8 months ago

So, now eyecheck will throw error and failed test accordingly. Regarding the node version, this lib has no control on which node version shall be supported rather depends on the CodeceptJS the Test Automation framework and Applitools lib.

AugustineJosephAlludo commented 8 months ago

@kobenguyent Thanks for the immediate fix. Its working as expected now