kodadot / nft-gallery

Generative Art Marketplace
https://koda.art
MIT License
634 stars 361 forks source link

Unable to set system theme if you enable dark/light manually #8554

Closed shashkovdanil closed 9 months ago

shashkovdanil commented 9 months ago

Is your feature request related to a problem?

If I manually switch the theme, I can't get the system theme back, which can be inconvenient

Describe the solution you would like

Usually, the theme switch has three states:

  1. Dark theme
  2. Light theme
  3. Automatic theme (taken from the system).

Describe alternatives you have considered

No response

Screenshots

No response

Are there opened related issues?

No response

roiLeo commented 9 months ago

If I manually switch the theme, I can't get the system theme back, which can be inconvenient

isn't it excepted result?

Let take for example a case:

shashkovdanil commented 9 months ago

We have to save the selected theme locally

Let's say it's localStorage:

  1. If the user did not choose the theme himself, there must be a system one
  2. If the user has enabled the dark/light theme themselves, there should be one

Now if I turn on the dark theme with my hands, I'll always have a dark theme. I can only get the system theme back if I clear local data (localStorage, cookies)

now user close brower, and when reopen Kodadot should be light mode instead of browser preference

Yes, If the user manually enabled the light theme, it should always be light, but there should be a way to return the system theme again, currently there is none

shashkovdanil commented 9 months ago

It's better UX when you can choose theme manually but you have opportunity to change it to System

image

roiLeo commented 9 months ago

We have to save the selected theme locally

nuxt-color-mode handle this

What's your concern with the theme feature? we've never had a problem with it, don't loose to much time focus on something derisory