Picker immediately closes after opening

[hamedbaatour]

Describe the bug picker closes as soon as it is clicked

To Reproduce

• load codemirror+codemirror-colorpicker
• remove editor from DOM (v-if/ng-if...)
• reinit codemirror editor (reinsert to DOM)
• try to open codemirror-colorpicker
• issue happens

Expected behavior picker should stay open

Screenshots picker opens and immediately the 'onchange' handler gets called and closes it.

Potential Fix / Additional Context

fixed the issue by removing cm.state.colorpicker.close_color_picker(); in side the OnChange function

function onChange(cm, evt) {
    if (evt.origin == 'setValue') {
       //  cm.state.colorpicker.close_color_picker();  // <========= removed this line
        cm.state.colorpicker.init_color_update();
        cm.state.colorpicker.style_color_update();
    } else {
        cm.state.colorpicker.style_color_update(cm.getCursor().line);
    }
}

Desktop

• OS: Windows
• Browser: all
• Version: latest 1.9.71

[easylogic]

hi @hamedbaatour

I fixed your issue. please try to test it on v1.9.72

[hamedbaatour]

@easylogic thanks for the quick fix. Really appreciate it 👍