search

kodyl / react-document-meta

HTML meta tags for React-based apps. Works for both client- and server-side rendering, and has a strict but flexible API.
MIT License
320 stars 23 forks source link

Add test coverage via babel-istanbul #16

Closed markdalgleish closed 8 years ago

markdalgleish commented 8 years ago

Your readme lists test coverage as a todo, and we're depending on this project in a project I'm working on, so I figured I'd send you a PR with babel-istanbul hooked up :smiley:

It was actually a bit tricky to get it to play nicely with Make, so you might find the test command somewhat cryptic, but unfortunately this was out of necessity.

Thank you so much for the awesome work!

danieljuhl commented 8 years ago

Thanks! I'll have a look later today and merge, if no questions arrive.

markdalgleish commented 8 years ago

Have you had a chance to have a look at this? I'm keen to continue helping out in this space :smiley:

danieljuhl commented 8 years ago

Sorry for the delay - will handle this now. Just a few moments..

markdalgleish commented 8 years ago

Thanks for merging!

danieljuhl commented 8 years ago

Thanks for your contribution!