When using jest this code gets transpiled to require and the file URL syntax of the import is not supported and breaks the testing environment. This change only uses file URL import syntax on windows machines. This fixes our tests and is still supported on linux and mac operating systems.
I think windows is definitely in the minority here and we should not optimize for it. Furthermore, I believe using a UNC path would be a better solution outright but I cannot test because I don't have a window machine at hand.
Why not just use jest's --experimental-vm-modules flag? Glad you asked. Because of this jest bug which is caused by this node bug which is ultimately caused by this v8 bug
Note: This checklist isn't meant to show up on the actual Pull Request (PR). It is added here to make you aware of items our maintainers will look for when reviewing your PR. If your PR is missing any of these items it will be rejected! Please delete this message and the following checklist and replace it with your own message as you see fit.
[x] I only have 1 commit.
[x] My commit is prefixed with the relevant package (e.g. express-openapi: fixing something) Note: You can use the bin/commit script to automate this.
[ ] I have added tests. (No, should be covered by existing regression tests)
[x] I'm using the latest code from the master branch and there are no conflicts on my branch.
[x] I have added a suffix to my commit message that will close any existing issue my PR addresses (e.g. openapi-jsonschema-parameters: Adding examples to the validation keywords (fixes #455)).
When using jest this code gets transpiled to
require
and the file URL syntax of the import is not supported and breaks the testing environment. This change only uses file URL import syntax on windows machines. This fixes our tests and is still supported on linux and mac operating systems.I think windows is definitely in the minority here and we should not optimize for it. Furthermore, I believe using a UNC path would be a better solution outright but I cannot test because I don't have a window machine at hand.
Why not just use jest's
--experimental-vm-modules
flag? Glad you asked. Because of this jest bug which is caused by this node bug which is ultimately caused by this v8 bugNote: This checklist isn't meant to show up on the actual Pull Request (PR). It is added here to make you aware of items our maintainers will look for when reviewing your PR. If your PR is missing any of these items it will be rejected! Please delete this message and the following checklist and replace it with your own message as you see fit.
express-openapi: fixing something
) Note: You can use the bin/commit script to automate this.openapi-jsonschema-parameters: Adding examples to the validation keywords (fixes #455)
).