search

kohler / click

The Click modular router: fast modular packet processing and analysis
Other
735 stars 322 forks source link

Add hotswapping to FromHost and ToHost elements #424

Open shlomos opened 5 years ago

shlomos commented 5 years ago

Signed-off-by: Shlomo Shenzis shlomo.shenzis@mail.huji.ac.il

tbarbette commented 5 years ago

Thanks for the PR. But please describe what it does in the commit messages (and in the pull request if it's multiple commits). About styling : do not replace spaces by tabs. And especially not in the same commit. Click uses generally 4 spaces and not tabs.

shlomos commented 5 years ago

Done. Removed all changes to blanks and added a description in the commit message.

shlomos commented 5 years ago

@tbarbette: Anything missing?

tbarbette commented 5 years ago

I do not handle non-DPDK related merges to mainline. If you feel like it you can open a PR to FastClick, I would merge it.