Closed rriggio closed 4 years ago
Hi,
I have opened a separate pull request because I have deleted the forked used for the previous one (sorry for the confusion).
This patch could be the basis for a revamped wifi support in click. However, revising all the existing wifi elements would require some time and for sure more than 2 hands. If anybody out there could be interested in this activity please let me know. Click has been a precious tool in my work and I would be happy to give back a bit.
R.
On Mon, 2 Dec 2019 at 00:51, Eddie Kohler notifications@github.com wrote:
@kohler commented on this pull request.
Thanks very much, Roberto, for keeping this going! Some nits; can you address them?
In elements/userlevel/fromdevice.cc https://github.com/kohler/click/pull/445#discussion_r352383551:
@@ -44,6 +44,7 @@
include
include
include "fakepcap.hh"
+#include <linux/sockios.h>
I think this needs to be under a Linux-specific #ifdef protection
In elements/userlevel/rawsocket.cc https://github.com/kohler/click/pull/445#discussion_r352383559:
@@ -34,6 +34,7 @@
include <sys/socket.h>
include <arpa/inet.h>
include
+#include <linux/sockios.h>
See above
In include/click/radiotap_iter.h https://github.com/kohler/click/pull/445#discussion_r352383747:
@@ -0,0 +1,94 @@ +#ifndef CLICK_RADIOTAP_ITER_H +#define CLICK_RADIOTAP_ITER_H
The extern C wrapping should go in the header file, I think, as it does in click/md5.h and click/crc32.h, rather than in the including files
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kohler/click/pull/445?email_source=notifications&email_token=AADXGTFMCEIRWJP3ROFHJATQWREZJA5CNFSM4JTDFO4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNPLHBQ#pullrequestreview-324973446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADXGTC2KB667ZBGAI5EN4DQWREZJANCNFSM4JTDFO4A .
This patch add support for 11n frame injection across the entire click router.