kokkos / kokkos-kernels

Kokkos C++ Performance Portability Programming Ecosystem: Math Kernels - Provides BLAS, Sparse BLAS and Graph Kernels
Other
311 stars 98 forks source link

workflows: adding variable to set kokkos version to test against #2389

Closed lucbv closed 1 month ago

lucbv commented 1 month ago

The variable is set directly in at2.yml so it can be uniformly applied to all the "sub-workflows" making maintenance when a new release of kokkos comes out easier.

cwpearson commented 1 month ago

I think this variable is not propagating properly. If you look at old actions the checkout part has a ref: field that is now missing, so we're pulling kokkos develop everywhere

cwpearson commented 1 month ago

May need to do something like this (untested)

jobs:
  call-workflow:
    uses: ./.github/workflows/reusable-workflow.yml
    with:
      my_var: ${{ vars.MY_VAR }}

and then in the reusable workflow

on:
  workflow_call:
    inputs:
      my_var:
        required: true
        type: string

jobs:
  reusable_job:
    runs-on: ubuntu-latest
    steps:
      - echo "The value of my_var is ${{ inputs.my_var }}"
lucbv commented 1 month ago

Yeah, I am looking at the documentation to get the appropriate github action syntax to propagate the variable correctly...

lucbv commented 1 month ago

@cwpearson it took me a minute to catch on what you were saying in your comment, I eventually read the documentation and figured out the syntax. Once small thing that remains unsatisfactory: we need to change the version in both at2.yml and osx.yml. I don't think I want to fix that now though...

lucbv commented 1 month ago

Ah and feel free to double check that everything does indeed build against kokkos 4.4.1. Thanks!

ndellingwood commented 1 month ago

The osx-ci jobs look unhappy about fetching the version,

  /opt/homebrew/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +refs/heads/$KOKKOS_VERSION*:refs/remotes/origin/$KOKKOS_VERSION* +refs/tags/$KOKKOS_VERSION*:refs/tags/$KOKKOS_VERSION*
  The process '/opt/homebrew/bin/git' failed with exit code 1
  Waiting 17 seconds before trying again
  /opt/homebrew/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +refs/heads/$KOKKOS_VERSION*:refs/remotes/origin/$KOKKOS_VERSION* +refs/tags/$KOKKOS_VERSION*:refs/tags/$KOKKOS_VERSION*
  The process '/opt/homebrew/bin/git' failed with exit code 1
  Waiting 15 seconds before trying again
  /opt/homebrew/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +refs/heads/$KOKKOS_VERSION*:refs/remotes/origin/$KOKKOS_VERSION* +refs/tags/$KOKKOS_VERSION*:refs/tags/$KOKKOS_VERSION*
  Error: The process '/opt/homebrew/bin/git' failed with exit code 1
ndellingwood commented 1 month ago

@lucbv osx builds look happier now :) I checked the output on one of the jobs to confirm it was using kokkos@4.4.01 as expected