search

kokkos / mdspan

Reference implementation of mdspan targeting C++23
Other
417 stars 69 forks source link

Return type of `layout_stride::operator()` is incorrect #200

Closed youyu3 closed 1 year ago

youyu3 commented 2 years ago

Should return index_type but returns size_t https://github.com/kokkos/mdspan/blob/stable/include/experimental/__p0009_bits/layout_stride.hpp#L426

mhoemmen commented 2 years ago

Confirmed, layout_stride::mapping::operator() should return index_type per the spec: http://eel.is/c++draft/views#mdspan.layout.stride.obs

crtrott commented 2 years ago

@youyu3 can you issue this against this repo too?

youyu3 commented 2 years ago

@crtrott Sure I'll upstream my fixes to this repo when I get a chance. Hopefully later this week.