kolide / launcher

Osquery launcher, autoupdater, and packager
https://kolide.com/launcher
Other
505 stars 100 forks source link

Add disable/delete ability to the Kolide Service #1709

Closed directionless closed 4 months ago

directionless commented 4 months ago

As we've worked with #1393, we've come to conclude that this functionality should be available through the device interface and not just the control interface. So at the simplest level, this issue is to add it there.

However, there is some additional worthwhile background.

  1. Launcher talks to the device server through the kolide service, which is implemented in go-kit.
  2. Launcher talks to the control server via some manual http stuff
  3. We are going to want to start evolving the device server interfaces

I am unsure if the split we have today makes the most sense. This is partly an opportunity to think about the next things we might want networking wise.

directionless commented 4 months ago

@James-Pickett -- This is done, right?

James-Pickett commented 4 months ago

@directionless, yep this closed by https://github.com/kolide/launcher/pull/1712