Refactoring install plugin script - Githubissues

komodorio / helm-dashboard

The missing UI for Helm - visualize your releases

Apache License 2.0

5k stars 302 forks source link

Refactoring install plugin script #427

Closed geet-h17 closed 1 year ago

geet-h17 commented 1 year ago

Changes Proposed

Refactored the installation script to improve functionality, efficiency, and maintainability.

Additional Information

I have made the following changes to the script:

Replaced inconsistent variable usage with consistent usage of the name variable.
Introduced functions to encapsulate repetitive code blocks.
Handled errors gracefully and provided informative error messages.
Validated the availability of required dependencies.
Used consistent indentation and formatting throughout the script.
Separated concerns into separate functions for version detection, downloading, and installation.

Screenshots

Check List

[ x] The title of my pull request is a short description of the changes
[ ] This PR relates to some issue:
[ x] I have documented the changes made (if applicable)
[ x] I have covered the changes with unit tests

undera commented 1 year ago

Thanks for the contribution!