search

kondrak / vkQuake2

id Software's Quake 2 v3.21 with mission packs and Vulkan support (Windows, Linux, macOS, FreeBSD, Raspberry Pi 4)
GNU General Public License v2.0
896 stars 91 forks source link

E2K: added initial support of MCST Elbrus 2000 CPU architecture #101

Closed r-a-sattarov closed 4 years ago

r-a-sattarov commented 4 years ago

E2K (Elbrus 2000) - this is VLIW/EPIC architecture, like Intel Itanium (IA-64) architecture.

Ref: https://en.wikipedia.org/wiki/Elbrus_2000

kondrak commented 4 years ago

Thanks for your contribution! The problem I see here is that you're directly modifying 3rd party libraries (miniaudio and vma) - I'd rather you submitted fixes to root repositories, so that it's official (at least vma is definitely going to be updated in the future in vkQuake2, so I'd rather avoid problems with losing custom fixes). Alternatively, if modifications can be avoided (or are maybe not necessary at all) I'd rather see it being done that way.

r-a-sattarov commented 4 years ago

Thanks for your contribution! The problem I see here is that you're directly modifying 3rd party libraries (miniaudio and vma) - I'd rather you submitted fixes to root repositories, so that it's official (at least vma is definitely going to be updated in the future in vkQuake2, so I'd rather avoid problems with losing custom fixes). Alternatively, if modifications can be avoided (or are maybe not necessary at all) I'd rather see it being done that way.

OK, I will submit fixes to root repositories of this libraries (miniaudio and vma).

r-a-sattarov commented 4 years ago

If everything is OK, can you please merge my PR?

kondrak commented 4 years ago

Ah, I didn't see you updated your code, looks fine now!