konflux-ci / build-definitions

Apache License 2.0
23 stars 133 forks source link

Make EC strict mode configurable #1630

Closed Zokormazo closed 1 day ago

Zokormazo commented 2 days ago

Allow modifying STRICT. This allows to mark an EC as informative and not gate changes on it.

This is useful for us while we iterate to fix all the violations without gating yet the pull requests

Zokormazo commented 2 days ago

This marks the TestIntegrationScenario green despite the violations, but the CI results on gitlab continues being red :(

The latter will need changes in the integration-service I guess

lcarva commented 2 days ago

/ok-ot-test

lcarva commented 2 days ago

I see the value of doing this, just please be wary that if the check is green no one usually digs through the check to see if there are any issues. If setting strict to false, there is a high chance that you won't find out about issues until release time which is usually not a great user experience.

Could you update the description of the parameter to provide some sort of warning to future users thinking about setting struct to false?

lcarva commented 2 days ago

/ok-to-test

(without typos now :sweat_smile:)

Zokormazo commented 1 day ago

Could you update the description of the parameter to provide some sort of warning to future users thinking about setting struct to false?

Sure

zregvart commented 1 day ago

/ok-to-test