search

konflux-ci / release-service

Kubernetes controller to manage releases in Stonesoup
11 stars 37 forks source link

fix(RELEASE-1150) add checks to fieldselectors #583

Closed happybhati closed 1 month ago

happybhati commented 1 month ago

This commit fixes the issue of FieldSelectors retrurning everything when the argument is nill, added checks to each function using field selector.

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.09%. Comparing base (a70b506) to head (fc70fe4). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #583 +/- ## ======================================== Coverage 84.09% 84.09% ======================================== Files 26 26 Lines 1635 1742 +107 ======================================== + Hits 1375 1465 +90 - Misses 182 192 +10 - Partials 78 85 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

happybhati commented 1 month ago

/retest

jinqi7 commented 1 month ago

/retest

happybhati commented 1 month ago

/retest

happybhati commented 1 month ago

Thanks, @johnbieren, for your approval.

@davidmogar Since you reviewed it earlier, please take a look whenever you get a chance. Ready to be merged!