Update links in DESCRIPTION

konfound-project / konfound

R package for carrying out sensitivity analysis

https://konfound-it.org/konfound/

Other

15 stars 8 forks source link

Update links in DESCRIPTION #66

Closed olivroy closed 7 months ago

olivroy commented 7 months ago

@jrosen48 for your deps you have to have a space between >= and the version

example

Matrix (>= 1.4)

jrosen48 commented 7 months ago

thanks for this @olivroy - I made the change in a commit -- https://github.com/konfound-project/konfound/commit/408fedbb676f848735c7d0d6b20c726e11fbabd0

olivroy commented 7 months ago

That is good! However, this was just a pointer to address the build failures. The goal of this PR is to correct the links in DESCRIPTION to account for the redirection + improve repo discoverability. https://blog.r-hub.io/2019/12/10/urls/

olivroy commented 7 months ago

Hi @jrosen48 , this PR is still valid since the package changed its homepage! Let me know if something is not clear!

jrosen48 commented 7 months ago

Ah hah! I now see. I'm sorry I didn't review this more carefully! Thanks for this edit! Good samaritan kudos!!! Thanks again.

jrosen48 commented 7 months ago

opening to merge

jrosen48 commented 7 months ago

thx again