konsultaner / connectanum-dart

This is a WAMP client (Web Application Messaging Protocol) implementation for the dart language and flutter projects.
MIT License
22 stars 14 forks source link

Payload Passthru Mode #52

Closed KSDaemon closed 2 years ago

KSDaemon commented 2 years ago

This PR includes:

There are definitely places to refactor and optimize but the main feature is working.

codecov[bot] commented 2 years ago

Codecov Report

Base: 91.47% // Head: 89.89% // Decreases project coverage by -1.57% :warning:

Coverage data is based on head (bf8169f) compared to base (9e4ffb2). Patch coverage: 74.02% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #52 +/- ## ========================================== - Coverage 91.47% 89.89% -1.58% ========================================== Files 41 44 +3 Lines 2638 2821 +183 ========================================== + Hits 2413 2536 +123 - Misses 225 285 +60 ``` | [Impacted Files](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard) | Coverage Δ | | |---|---|---| | [lib/src/authentication/scram\_authentication.dart](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard#diff-bGliL3NyYy9hdXRoZW50aWNhdGlvbi9zY3JhbV9hdXRoZW50aWNhdGlvbi5kYXJ0) | `97.72% <ø> (ø)` | | | [lib/src/message/abstract\_ppt\_options.dart](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard#diff-bGliL3NyYy9tZXNzYWdlL2Fic3RyYWN0X3BwdF9vcHRpb25zLmRhcnQ=) | `0.00% <0.00%> (ø)` | | | [lib/src/message/details.dart](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard#diff-bGliL3NyYy9tZXNzYWdlL2RldGFpbHMuZGFydA==) | `100.00% <ø> (ø)` | | | [lib/src/message/subscribed.dart](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard#diff-bGliL3NyYy9tZXNzYWdlL3N1YnNjcmliZWQuZGFydA==) | `100.00% <ø> (ø)` | | | [lib/src/protocol/e2ee\_payload.dart](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard#diff-bGliL3NyYy9wcm90b2NvbC9lMmVlX3BheWxvYWQuZGFydA==) | `0.00% <0.00%> (ø)` | | | [lib/src/message/call.dart](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard#diff-bGliL3NyYy9tZXNzYWdlL2NhbGwuZGFydA==) | `69.23% <55.55%> (-30.77%)` | :arrow_down: | | [lib/src/protocol/ppt\_payload.dart](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard#diff-bGliL3NyYy9wcm90b2NvbC9wcHRfcGF5bG9hZC5kYXJ0) | `58.62% <58.62%> (ø)` | | | [lib/src/message/registered.dart](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard#diff-bGliL3NyYy9tZXNzYWdlL3JlZ2lzdGVyZWQuZGFydA==) | `80.95% <63.63%> (-19.05%)` | :arrow_down: | | [lib/src/message/publish.dart](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard#diff-bGliL3NyYy9tZXNzYWdlL3B1Ymxpc2guZGFydA==) | `81.81% <66.66%> (-18.19%)` | :arrow_down: | | [lib/src/message/invocation.dart](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard#diff-bGliL3NyYy9tZXNzYWdlL2ludm9jYXRpb24uZGFydA==) | `86.66% <69.23%> (-13.34%)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/konsultaner/connectanum-dart/pull/52/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Richard)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

konsultaner commented 2 years ago

@KSDaemon Thanks for all the work :) I'm not a contribution pro, so one stupid question. Can I somehow edit your code? I would like to reorder some of it. I would also like to add some unit tests and rename some code parts.

KSDaemon commented 2 years ago

Hi, @konsultaner! Well, there are a few possible options for your question:

I'll be glad to become a real contributor here. It also helps btw in code review flows, issues labeling and etc. But of course, it's up to you.

konsultaner commented 2 years ago

@KSDaemon I'll add you as a contributor, but please always use PR's and never work on master directly! I'd love to keep my code style ;)

KSDaemon commented 2 years ago

@konsultaner Thnx! Well, it is not only your own code style but a community-wide ;) In any project with more than one developer all code should be developed and reviewed through the PRs! So let's work on this together!

konsultaner commented 2 years ago

@KSDaemon sorry, my first project with larger contributions from other developers 🙈

KSDaemon commented 2 years ago

@konsultaner Don't worry! No problem! I'm glad to help! Just msg me here, by email, or any messenger.

konsultaner commented 2 years ago

@KSDaemon do I need to start the new branch or can you do this now?

KSDaemon commented 2 years ago

Closing in favor of https://github.com/konsultaner/connectanum-dart/pull/53

KSDaemon commented 2 years ago

@konsultaner Thnx for inviting me! See https://github.com/konsultaner/connectanum-dart/pull/53. Feel free to checkout to ppt-mode branch sync with master and update as needed.