Closed KSDaemon closed 2 years ago
Base: 91.47% // Head: 89.89% // Decreases project coverage by -1.57%
:warning:
Coverage data is based on head (
bf8169f
) compared to base (9e4ffb2
). Patch coverage: 74.02% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@KSDaemon Thanks for all the work :) I'm not a contribution pro, so one stupid question. Can I somehow edit your code? I would like to reorder some of it. I would also like to add some unit tests and rename some code parts.
Hi, @konsultaner! Well, there are a few possible options for your question:
I'll be glad to become a real contributor here. It also helps btw in code review flows, issues labeling and etc. But of course, it's up to you.
@KSDaemon I'll add you as a contributor, but please always use PR's and never work on master directly! I'd love to keep my code style ;)
@konsultaner Thnx! Well, it is not only your own code style but a community-wide ;) In any project with more than one developer all code should be developed and reviewed through the PRs! So let's work on this together!
@KSDaemon sorry, my first project with larger contributions from other developers 🙈
@konsultaner Don't worry! No problem! I'm glad to help! Just msg me here, by email, or any messenger.
@KSDaemon do I need to start the new branch or can you do this now?
Closing in favor of https://github.com/konsultaner/connectanum-dart/pull/53
@konsultaner Thnx for inviting me!
See https://github.com/konsultaner/connectanum-dart/pull/53. Feel free to checkout to ppt-mode
branch sync with master and update as needed.
This PR includes:
payload_transparency
feature and now is officially described in WAMP specoptions/details
parameter, some API method were modified (e.g. instead of passing just one positional boolean argument forprogress
, now options are done mostly everywhere across library in same manner: named arguments to be able to pass all desired options at once)There are definitely places to refactor and optimize but the main feature is working.